Skip to content

[5.1] [Typechecker] Ban tuples with duplicate labels #24919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

[5.1] [Typechecker] Ban tuples with duplicate labels #24919

merged 1 commit into from
May 23, 2019

Conversation

theblixguy
Copy link
Collaborator

@theblixguy theblixguy commented May 20, 2019 •
edited
Loading

Cherry-pick of #24774.

This PR bans tuples with duplicate labels. For example:

let f: (foo: Int, foo: Int) = (foo: 1, foo: 2)

Resolves SR-8974
Resolves rdar://problem/45218256

@theblixguy
Copy link
Collaborator Author

cc @jrose-apple

@jrose-apple
Copy link
Contributor

@swift-ci Please test

@jrose-apple jrose-apple self-assigned this May 20, 2019
@slavapestov slavapestov merged commit 3892296 into swiftlang:swift-5.1-branch May 23, 2019
@theblixguy theblixguy deleted the fix/ban-dup-tuple-element-labels-5.1 branch July 16, 2019 20:24
@theblixguy theblixguy mentioned this pull request Jul 16, 2019
Merged
@theblixguy theblixguy mentioned this pull request May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrose-apple jrose-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theblixguy @jrose-apple @slavapestov