Skip to content

[5.1-04-24] Fix closurescope analysis and capture promotion #24927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

[5.1-04-24] Fix closurescope analysis and capture promotion #24927

merged 1 commit into from
May 23, 2019

Conversation

aschwaighofer
Copy link
Contributor

  • CapturePromotion: Disable for dynamically_replaceable sil functions

rdar://50949761

@aschwaighofer
[5.1-04-24] Fix closurescope analysis and capture promotion
9d96163 
* CapturePromotion: Disable for dynamically_replaceable sil functions

rdar://50949761
@aschwaighofer aschwaighofer requested a review from a team as a code owner May 20, 2019 20:42
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@bob-wilson
Copy link
Contributor

This looks good to me, but I'll hold off approving it until the master PR gets a review from someone else.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9d96163

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9d96163

@najacque
Copy link
Contributor

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9d96163

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9d96163

@shahmishal
Copy link
Member

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9d96163

@aschwaighofer
Copy link
Contributor Author

The linux failure is unrelated.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9d96163

@aschwaighofer
Copy link
Contributor Author

The mac os x failure is unrelated (same failure).

@najacque najacque merged commit cfdedde into swiftlang:swift-5.1-branch-04-24-2019 May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bob-wilson bob-wilson bob-wilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aschwaighofer @bob-wilson @swift-ci @najacque @shahmishal