[TF] Further cleanup of CompilerRuntime and friends #24938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test tensorflow |
1 similar comment
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
May 21, 2019
| @@ -91,9 +90,7 @@ extension TestSuite { | |||
| public func testTPU(_ name: String, _ body: @escaping () -> Void) { | |||
| #if TPU | |||
| test(name + "_TPU") { | |||
There was a problem hiding this comment.
I think all these test functions are also obsolete actually.
There was a problem hiding this comment.
@rxwei I've done some further cleanup. PTAL.
burmako
changed the title
burmako
changed the title
|
@swift-ci Please test tensorflow |
1 similar comment
|
@swift-ci Please test tensorflow |
|
@swift-ci I'm begging you please test tensorflow |
added 4 commits
May 20, 2019 20:03
* TF_CreateConfig.enable_xla_compilation is now hardcoded to 0. * TPU tests now unconditionally fail instead of pretending to work.
These functions have empty bodies, but they have pretty high-profile names which gives an impression that they do something important. With that in mind, I think it would be best to remove these functions without any deprecation notice because there aren't any comparable replacements at the moment.
This commit removes the remnants of the obsolete TPU testing infrastructure. In the nearest future, we are planning to restore it within the new tracing runtime (https://bugs.swift.org/browse/TF-520).
This commit removes the remnants of the obsolete TPU runtime infrastructure. In the nearest future, we are planning to restore it within the new tracing runtime (https://bugs.swift.org/browse/TF-519).
rxwei
approved these changes
May 21, 2019
|
@swift-ci Please test tensorflow |
1 similar comment
|
@swift-ci Please test tensorflow |
|
Merging while the macOS job is running, since it is expected that this job will fail anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting started with TPU support, and this functionality wasn't doing what it was advertising. After a chat with the team, I learned that it was designed to work with GPE, and with GPE gone it doesn't make much sense anymore. Therefore, I decided to go ahead and remove it.