[AutoDiff] Fix autodiff_function
instruction worklist.
#24941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
autodiff_function
instruction worklist registration/invalidation.VJPEmitter
, add clonedautodiff_function
instructions in VJPto worklist.
autodiff_function
instructions are deleted infoldAutoDiffFunctionExtraction
, also remove their worklist occurrences.Resolves TF-515.
Writing a reproducer test is difficult because the nature of the bug is ad-hoc.
Verified that
swift test
works for tensorflow/swift-models@f9687bf.