Skip to content

[5.1][CodeCompletion] '#file', '#line', et al. after '#' #24983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 22, 2019
Merged

[5.1][CodeCompletion] '#file', '#line', et al. after '#' #24983

merged 4 commits into from
May 22, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 22, 2019

Cherry-pick of #24969 to swift-5.1-branch reviewed by @benlangmuir

rdar://problem/47169238

rintaro added 4 commits May 22, 2019 10:39
@rintaro
[CodeCompletion] Suggest 'file', 'line', et al. after #
a3e3d3e 
rdar://problem/47169238
(cherry picked from commit 83084e2)
@rintaro
[CodeCompletion] Use CompletionLookup.CurrModule instance property
a534050 
(cherry picked from commit 3c957de)
@rintaro
[CodeCompletion] Suggest #selector and #keyPath after # only if appli…
b640033 
…cable

Also, add type annotation, and make it `TypeRelation[Identical]`.
'ExprSpecific' is too strong.

(cherry picked from commit e2a4621)
@rintaro
[CodeCompletion] Added test case for polymorphic type keywords
3899a17 
(cherry picked from commit c001483)
@rintaro rintaro changed the base branch from master to swift-5.1-branch May 22, 2019 17:41
@rintaro
Copy link
Member Author

rintaro commented May 22, 2019

@swift-ci Please test

@rintaro rintaro merged commit e31ee16 into swiftlang:swift-5.1-branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rintaro