[CodeCompletion] Context type analysis for default argument initializer #24987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
May 22, 2019
|
It seems this doesn't work at default argument for enum element. e.g. enum MyEnum {
case something(thing: Something = .<HERE>)
}I will rethink. |
|
@swift-ci Please smoke test |
rdar://problem/51037538
rintaro
force-pushed
the
ide-completion-defaultinit-rdar51037538
branch
from
3050609 to
f94a6c0
Compare
|
@swift-ci Please smoke test |
This was referenced Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables implicit member expression completion at default argument initializer position. e.g.
rdar://problem/51037538