[5.1][Diagnostics] Assignment diagnostic improvements #24988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… collection element types
Detect and diagnose a contextual mismatch between expected
collection element type and the one provided (e.g. source
of the assignment or argument to a call) e.g.:
```swift
let _: [Int] = ["hello"]
func foo(_: [Int]) {}
foo(["hello"])
```
(cherry picked from commit b9a0ca6)
(cherry picked from commit 7448507)
(cherry picked from commit e39d236)
….. in <expr>` loop (cherry picked from commit 1cc6f77)
… protocol type Switch type allows "missing conformance" diagnostic to be used not only for protocols by for protocol compositions as well. (cherry picked from commit ace86e8)
…al failures Extend use of `missing protocol conformance` fix to cover contextual failures, such as: - Assignment mismatches, where destination requires source to conform to certain protocol (or protocol composition); - Incorrect returns where returned type doesn't conform to the protocol specified in the signature. (cherry picked from commit ada6ab5)
…chExistentialTypes` (cherry picked from commit 17643a3)
…smatches related to protocols (cherry picked from commit e76ae9c)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for ... in <expr>loop;to certain protocol (or protocol composition);
Resolves: rdar://problem/49400007