SILCombine: We are not guaranteed to get a function_ref instruction here #25014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix an issue in that cast optimizer and objc bridging thunks that are marked dynamic. Same test case tests both issues. rdar://51068786
|
@swift-ci Please test |
aschwaighofer
commented
May 23, 2019
| @@ -271,7 +271,7 @@ CastOptimizer::optimizeBridgedObjCToSwiftCast(SILDynamicCastInst dynamicCast) { | |||
| // Now emit the a cast from the casted ObjC object into a target type. | |||
| // This is done by means of calling _forceBridgeFromObjectiveC or | |||
| // _conditionallyBridgeFromObjectiveC_bridgeable from the Target type. | |||
| auto *funcRef = Builder.createFunctionRef(Loc, bridgingFunc); | |||
| auto *funcRef = Builder.createFunctionRefFor(Loc, bridgingFunc); | |||
There was a problem hiding this comment.
createFunctionRefFor takes [dynamically_replacable] into account and generates either a function_ref or a dynamic_function_ref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix an issue in that cast optimizer and objc bridging thunks that
are marked dynamic.
Same test case tests both issues.
rdar://51068786