[Test] Use --allow-empty in crash_without_backtrace_optimized.swift. #25017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Mike, can you perform not just a full test, but also use the custom preset swift-ci command to test this without assertions. Also I just merged to master a commit that disabled the test so you probably need to rebase this change (delete the REQUIRES line) and restart the testing. |
mikeash
force-pushed
the
fix-crash-without-backtrace-optimized2
branch
from
2a2e0f5 to
20b24c5
Compare
|
preset=buildbot,tools=RA,stdlib=RD |
|
preset=buildbot,tools=RA,stdlib=RD |
|
Passed with the presets. Running normal tests and merging (if they're OK too). |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/51076215