Skip to content

[benchmark] ReportFormatter: Improved single_table headers #25027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 24, 2019

Conversation

palimondo
Copy link
Contributor

This PR improves single_table mode of ReportFormatter:

  • Add unit test coverage.
  • Print labels for the numeric columns on inline headers.
  • Visually distinguish sections by a separator row preceding the the inline headers.
  • Separate header label styles for git and markdown modes with UPPERCASE and Bold formatting respectively.

palimondo added 7 commits May 22, 2019 14:54
Remove unnecessary list-to-tuple conversions.
It is slightly faster to simply concatenate strings that don’t require special formatting.
Confine the logic for printing headers to the header function.
Improve inline headers in `single_table` mode to also print labels for the numeric columns.

Sections in the `single_table` are visually distinguished by a separator row preceding the the inline headers.

Separated header label styles for git and markdown modes with UPPERCASE and **Bold**  formatting respectively.

Inlined section template definitions.
@palimondo palimondo requested a review from eeckstein May 23, 2019 21:32
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

I'm hoping some false change will pop up during benchmark, otherwise I will have to commit and revert some renamed benchmark… 🤞.

@PFCAwesome
Copy link

PFCAwesome commented May 23, 2019 via email

@swift-ci
Copy link
Contributor

Performance: -O

Code size: -O

Performance: -Osize

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Added MIN MAX MEAN MAX_RSS
ArrayValueProp42 4 4 4
 
Removed MIN MAX MEAN MAX_RSS
ArrayValueProp4 4 5 4

Code size: -O

Regression OLD NEW DELTA RATIO
ArrayLiteral.o 3311 3352 +1.2% 0.99x

Performance: -Osize

Improvement OLD NEW DELTA RATIO
LuhnAlgoEager 656 613 -6.6% 1.07x (?)
 
Added MIN MAX MEAN MAX_RSS
ArrayValueProp42 4 4 4
 
Removed MIN MAX MEAN MAX_RSS
ArrayValueProp4 4 4 4

Code size: -Osize

Performance: -Onone

Added MIN MAX MEAN MAX_RSS
ArrayValueProp42 2785 2928 2833
 
Removed MIN MAX MEAN MAX_RSS
ArrayValueProp4 2778 2817 2791

Code size: -swiftlibs

Benchmark Check Report
⚠️ ArrayValueProp42 execution took 4 μs.
Increase the workload of ArrayValueProp42 to be more than 20 μs.
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@palimondo
Copy link
Contributor Author

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit d1a1ed1 into swiftlang:master May 24, 2019
@palimondo palimondo deleted the single-table++ branch May 24, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants