-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[benchmark] ReportFormatter: Improved single_table headers #25027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove unnecessary list-to-tuple conversions.
It is slightly faster to simply concatenate strings that don’t require special formatting.
Confine the logic for printing headers to the header function.
Improve inline headers in `single_table` mode to also print labels for the numeric columns. Sections in the `single_table` are visually distinguished by a separator row preceding the the inline headers. Separated header label styles for git and markdown modes with UPPERCASE and **Bold** formatting respectively. Inlined section template definitions.
@swift-ci please benchmark |
I'm hoping some false change will pop up during benchmark, otherwise I will have to commit and revert some renamed benchmark… 🤞. |
Stop
…On Thu, May 23, 2019, 16:37 Pavol Vaskovic ***@***.***> wrote:
I'm hoping some false change will pop up during benchmark, otherwise I
will have to commit and revert some renamed benchmark… 🤞.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25027>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGVJKIGODO7QAJMXHSV4BQDPW4FBRANCNFSM4HPKO3UQ>
.
|
Performance: -OCode size: -OPerformance: -OsizeCode size: -OsizePerformance: -OnoneCode size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
@swift-ci please benchmark |
Performance: -O
Code size: -O
Performance: -Osize
Code size: -OsizePerformance: -Onone
Code size: -swiftlibs
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
@swift-ci smoke test and merge |
This PR improves
single_table
mode ofReportFormatter
:git
andmarkdown
modes with UPPERCASE and Bold formatting respectively.