fix @differentiable function in .swiftinterface #25059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
May 25, 2019
There was a problem hiding this comment.
Nice. Thanks!
I think we should make this test be located in test/AutoDiff as differentiable_attr_parseable_interface.swift for now. Similarly, while a lot other test files in test/AutoDiff should in principle be in other test folders, we grouped them in the same folder in order to easily identify what to upstream when the time comes.
added 3 commits
May 24, 2019 20:16
|
Okay, I tried re-enabling that. But it is still failing just as much as before. So I un-re-enabled it. |
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While messing with .swiftinterface files, I discovered that
@differentiablefunctions don't get printed correctly in .swiftinterface files.The test in
test/AutoDiff/differentiable_attr_parseable_interface.swiftdemonstrates what this fixes.The extra test in
test/Serialization/differentiable_attr.swiftwas already passing before this change, but I noticed that that file didn't have a@differentiablefunction as a param, so I thought it would be good it to add to that file too.