Skip to content

Add build-script -a/-A to control assertions #25063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2019
Merged

Add build-script -a/-A to control assertions #25063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/build_swift/driver_arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,12 +663,12 @@ def create_argument_parser():
set_defaults(assertions=True)

# TODO: Convert to store_true
option('--assertions', store,
option(['-a', '--assertions'], store,
const=True,
help='enable assertions in all projects')

# TODO: Convert to store_false
option('--no-assertions', store('assertions'),
option(['-A', '--no-assertions'], store('assertions'),
const=False,
help='disable assertions in all projects')

Expand Down
2 changes: 2 additions & 0 deletions utils/build_swift/tests/expected_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,11 @@ class IgnoreOption(_BaseOption):
SetOption('-s', dest='test_optimize_for_size', value=True),
SetOption('-y', dest='test_optimize_none_implicit_dynamic', value=True),
SetOption('-t', dest='test', value=True),
SetOption('-a', dest='assertions', value=True),

# FIXME: Convert these options to set_false actions
SetOption('--no-assertions', dest='assertions', value=False),
SetOption('-A', dest='assertions', value=False),
SetOption('--no-lldb-assertions', dest='lldb_assertions', value=False),
SetOption('--no-llvm-assertions', dest='llvm_assertions', value=False),
SetOption('--no-llbuild-assertions',
Expand Down