Skip to content

[build-script] Add a preset for building the stdlib against a swift.o… #25078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2019

Conversation

gottesmm
Copy link
Contributor

…rg toolchain.

This is partly to provide an easy way for people to build the stdlib against a
toolchain. Sadly, it seems to not be able to build against the tests due to our
tests seemingly requiring our tools. We should be able to split out the stdlib
only tests. But, this at least is a way forward and an example.

The preset is called "stdlib_RDA,standalone,notest". It requires one parameter:
toolchain_path which should be the bin directory of your toolchain. Example:

build-script --preset=stdlib_RDA,standalone,notest toolchain_path=$MY_TOOLCHAIN/usr/bin

@gottesmm gottesmm requested a review from shahmishal May 27, 2019 02:51
@gottesmm
Copy link
Contributor Author

@shahmishal what do you think?

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@shahmishal
Copy link
Member

LGTM! You will need to update the test Python/build_swift.swift

@gottesmm gottesmm force-pushed the standalone_stdlib_preset branch from b7b9a10 to 2b571d5 Compare May 29, 2019 01:33
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

3 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm merged commit f8ad395 into swiftlang:master May 29, 2019
@gottesmm gottesmm deleted the standalone_stdlib_preset branch May 29, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants