Skip to content

[tests] Add support for running executable tests when SWIFT_INCLUDE_T… #25103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

…OOLS is set to false.

The two changes here are that:

  1. We do not create dependencies from lit on the non-existant swift tools.
  2. I added a lit feature called 'swift_tools_extra' that marks some executable
    tests that use extra tools that we build normally but that are not put in
    toolchains.

@gottesmm gottesmm requested a review from compnerd May 28, 2019 23:20
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test OS X platform

…OOLS is set to false.

The two changes here are that:

1. We do not create dependencies from lit on the non-existant swift tools.
2. I added a lit feature called 'swift_tools_extra' that marks some executable
tests that use extra tools that we build normally but that are not put in
toolchains.
@gottesmm gottesmm force-pushed the pr-f84811812599fd979ceedad733e34a66ca2d6d9d branch from 7966636 to 8284379 Compare May 29, 2019 00:21
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test OS X platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test OS X platform

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

2 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments!

@gottesmm gottesmm merged commit 7dc497c into swiftlang:master May 29, 2019
@gottesmm gottesmm deleted the pr-f84811812599fd979ceedad733e34a66ca2d6d9d branch May 29, 2019 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants