Skip to content

[test] Mark SR-10600.swift as executable. #25128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drodriguez
Copy link
Contributor

Android CI do not run the executable tests because there's no device
attached, but this test was not marked to be skipped, and it broke the
Android CI.

See https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/918/ and https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/2699/

Android CI do not run the executable tests because there's no device
attached, but this test was not marked to be skipped, and it broke the
Android CI.
@drodriguez drodriguez requested review from compnerd and jckarter May 29, 2019 23:01
@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test

@drodriguez drodriguez merged commit 24d23a0 into swiftlang:master May 30, 2019
@drodriguez drodriguez deleted the android-sr-10600-executable-test branch May 30, 2019 00:59
@jckarter
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants