[Constant evaluator] Add support for destructure_tuple and destructure_struct instructions to the constant evaluator. #25133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destructure_struct instructions to the constant evaluator.
|
@swift-ci Please test |
|
Build failed |
gottesmm
reviewed
May 30, 2019
| @@ -1370,6 +1370,23 @@ ConstExprFunctionState::evaluateFlowSensitive(SILInstruction *inst) { | |||
| return None; | |||
| } | |||
|
|
|||
| if (isa<DestructureTupleInst>(inst) || isa<DestructureStructInst>(inst)) { | |||
There was a problem hiding this comment.
I think you could probably do this in a more general way, but I think for now this is fine.
|
@swift-ci Please test macOS Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.