FIx an overrelease in StdlibUnittest's getSystemVersionPlistProperty #25135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://51245681
The comment in the function said: // This function is implemented in Objective-C because Swift does not support // failing initializers. which hasn't been true since swift 1.1.
|
@swift-ci smoke test |
|
I'm not sure if I put the test in the right place. The other CC @Catfish-Man |
|
I'll fix the Linux failure by adding |
|
@swift-ci smoke test |
|
@swift-ci Python lint |
|
@swift-ci smoke test |
|
@swift-ci Python lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getSystemVersionPlistPropertyoverreleases objects if certainStdlibUnittestinitialization happens inside an autoreleasepool. Just picking two lines from the function:the
+stringWithUTF8String:method returns an autoreleased object, so explicitly releasing it is an overrelease.Steps To Reproduce
Write a
StdlibUnittestfile that has at least one.xfailor.skip, and that callsrunAllTests()from inside an autoreleasepool block. The test included with the PR crashed with a SIGILL before, and passes now.Fixes rdar://51245681