Fix a potential race condition in StdlibUnittest #25136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StdlibUnittest uses an AtomicBool to track whether a failure has ocurred in a test. Before this, expectFailure could have a false-positive failure due to a race condition on the _anyExpectFailed. The following interleaving would trigger the issue: A: loads false A: stores false B: loads false A: stores true B: stores false A: loads false (after body) This causes A to see a false-positive failure.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StdlibUnittestuses anAtomicBoolto track whether a failure has ocurred in a test. Without these changes,expectFailurecould have a false-positive failure due to a race condition on the_anyExpectFailedvariable.I believe the following interleaving of two threads
AandBwould trigger the issue:which causes A to see a false-positive failure.
Fixes rdar://51247527
CC @lorentey