IRGen/runtime: change the code generation for dynamically replaceable functions #25154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions Instead of a thunk insert the dispatch into the original function. If the original function should be executed the prolog just jumps to the "real" code in the function. Otherwise the replacement function is called. There is one little complication here: when the replacement function calls the original function, the original function should not dispatch to the replacement again. To pass this information, we use a flag in thread local storage. The setting and reading of the flag is done in two new runtime functions. rdar://problem/51043781
…al and not specific to exclusivity checking. Just a refactoring, NFC
With the option -Xllvm -basic-dynamic-replacement the runtime functions are not called (so it works with an old swift library). But calling the original of a replaced function is not supported in this case.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a thunk insert the dispatch into the original function.
If the original function should be executed the prolog just jumps to the "real" code in the function. Otherwise the replacement function is called.
There is one little complication here: when the replacement function calls the original function, the original function should not dispatch to the replacement again.
To pass this information, we use a flag in thread local storage.
The setting and reading of the flag is done in two new runtime functions.
rdar://problem/51043781