-build-module-from-parseable-interface: Don't make an extra ASTContext #25185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mode is supposed to get all its configuration information from the switftinterface being read in, but that means that the ASTContext and ClangImporter that get created by default may not be a sensible configuration (for example, a mismatched target and SDK, which Clang emits a warning about). Avoid this by just not creating the ASTContext if it's already been determined that the frontend is building a module from a parseable interface.
|
@swift-ci Please test |
nathawes
approved these changes
Jun 1, 2019
|
Build failed |
|
@swift-ci Please test |
harlanhaskins
approved these changes
Jun 1, 2019
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 1, 2019
swiftlang#25185) This mode is supposed to get all its configuration information from the switftinterface being read in, but that means that the ASTContext and ClangImporter that get created by default may not be a sensible configuration (for example, a mismatched target and SDK, which Clang emits a warning about). Avoid this by just not creating the ASTContext if it's already been determined that the frontend is building a module from a parseable interface. (cherry picked from commit 0f45437)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mode is supposed to get all its configuration information from the switftinterface being read in, but that means that the ASTContext and ClangImporter that get created by default may not be a sensible configuration (for example, a mismatched target and SDK, which Clang emits a warning about). Avoid this by just not creating the ASTContext if it's already been determined that the frontend is building a module from a
parseablemodule interface.