Skip to content

[5.1] [SE-0258] More property wrapper fixes #25201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2019
Merged

[5.1] [SE-0258] More property wrapper fixes #25201

merged 4 commits into from
Jun 3, 2019

Conversation

DougGregor
Copy link
Member

Bring over a few fixes for property wrappers:

  • Clarify diagnostic banning '$' identifiers.
  • Drop the lowercasing restriction on property wrapper names.
  • Fix crash-on-invalid involving some wrappers with wrapperValue (rdar://problem/51193573)

DougGregor added 4 commits June 1, 2019 21:37
@DougGregor
[SE-0258] Clarify diagnostic banning '$' identifiers.
d3de3a7 
Thanks to Zachary Waldowski for helping clarify this.

(cherry picked from commit a0aaca1)
@DougGregor
[SE-0258] Drop the lowercasing restriction on property delegate names.
204c073 
(cherry picked from commit e009a1a)
@DougGregor
[SE-0258] Minor diagnostic fix for $ and a test case update
5efe60a 
(cherry picked from commit d430ddb)
@DougGregor
[SE-0258] Fix crash-on-invalid involving some wrappers with wrapperValue
1d5c534 
Fixes rdar://problem/51193573.

(cherry picked from commit be2867f)
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit e5aafaa into swiftlang:swift-5.1-branch Jun 3, 2019
@DougGregor DougGregor deleted the property-wrappers-more-fixes branch June 3, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougGregor