test: plumb --triple to the resilience test helper
#25209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @slavapestov @mikeash |
|
@swift-ci please smoke test |
The resilience test helper builds up invocations of the tooling. In order to do this, we need to know what host we are building for. Plumb the value for `-triple` from the test harness into the utility. This will be used subsequently to enable additional testing for Windows.
compnerd
force-pushed
the
there-is-a-crack-in-the-plumbing
branch
from
fd946df to
1e630a5
Compare
|
@swift-ci please smoke test |
|
Build failed |
|
Build failed |
|
LGTM. @slavapestov is more familiar with this than me, though, so he should weigh in too. |
|
This is currently not doing any changes, so Im going to merge this for the next set of changes. I can address any additional comments from @slavapestov post-commit if there are any. |
|
Righto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resilience test helper builds up invocations of the tooling. In
order to do this, we need to know what host we are building for. Plumb
the value for
-triplefrom the test harness into the utility. Thiswill be used subsequently to enable additional testing for Windows.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.