[build-script] Add support for passing --reconfigure to arbitrary presets and remove --reconfigure from stdlib standalone presets #25214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci python lint |
This works just by passing reconfigure to build-script-impl. This lets one remove --reconfigure from presets and let the invoker of the preset decide whether or not to to reconfigure.
…e presets. With the previous commit, one can choose when to reconfigure. I have noticed that when we reconfigure the preset, we always rebuild. So having reconfigure by default messes with the experience of using the preset.
gottesmm
force-pushed
the
pr-ca4f1e17cef6e16b8230c7664a43cddd822909fd
branch
from
7d6f131 to
af77f11
Compare
|
@swift-ci python lint |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that if one reconfigures the standalone presets, we seem to always rebuild everything. To work around this, I added a --reconfigure option to build-script's preset code to allow one to add --reconfigure to arbitrary build-script-impl lines. This then lets me make the default behavior of the standalone stdlib be to /not/ reconfigure.