Skip to content

test: add a workaround for rth invocation #25219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jun 3, 2019

The rth tool is a python script and relied on the execution via the
shebang. However, not all targets support the shebang to invoke the
interpreter. Explicitly launch the resilience test helper with the
interpreter (python). Ideally, we would use the %rth substitution,
but that does not seem to function for the nested case here.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2019

CC: @jrose-apple @slavapestov

@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2019

@swift-ci please smoke test

The `rth` tool is a python script and relied on the execution via the
shebang.  However, not all targets support the shebang to invoke the
interpreter.  Explicitly launch the resilience test helper with the
interpreter (python).  Ideally, we would use the `%rth` substitution,
but that does not seem to function for the nested case here.
@compnerd compnerd force-pushed the interpretation-dictionary branch from 6967d65 to 48976e5 Compare June 3, 2019 22:33
@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2019

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 3, 2019

Build failed
Swift Test Linux Platform
Git Sha - 6967d6566c7431b558309d5060f58d93eeddf899

@swift-ci
Copy link
Contributor

swift-ci commented Jun 3, 2019

Build failed
Swift Test OS X Platform
Git Sha - 6967d6566c7431b558309d5060f58d93eeddf899

@compnerd
Copy link
Member Author

compnerd commented Jun 4, 2019

@swift-ci please smoke test macOS platform

@compnerd compnerd merged commit 3d2bead into swiftlang:master Jun 4, 2019
@compnerd compnerd deleted the interpretation-dictionary branch June 4, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants