Skip to content

Remove all available 9999 now that 10.15, iOS 13, etc are public. #25230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Remove all available 9999 now that 10.15, iOS 13, etc are public. #25230

wants to merge 4 commits into from

Conversation

stephentyrone
Copy link
Contributor

No description provided.

@stephentyrone
Copy link
Contributor Author

@jckarter please confirm that the availability updates in test/Interpreter and test/ParseableInterfaces are correct.

@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - 63bd4b1972f4aaa535f13f7f9d7835c9b4ecbd5a

jckarter
jckarter approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve! Looks good.

lorentey
lorentey approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The patch adds some extra newlines in unrelated files. I think we should keep them.

@lorentey
Copy link
Member

Master is now building with Xcode 11; this will have a better chance of passing tests now.

@lorentey
Copy link
Member

@swift-ci test macOS platform

@lorentey lorentey mentioned this pull request Jun 11, 2019
Merged
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 63bd4b1972f4aaa535f13f7f9d7835c9b4ecbd5a

@lorentey lorentey mentioned this pull request Jun 11, 2019
Merged
@stephentyrone
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 63bd4b1972f4aaa535f13f7f9d7835c9b4ecbd5a

@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@swift-ci

This comment has been minimized.

Sign in to view
@swift-ci

This comment has been minimized.

Sign in to view
@stephentyrone
Copy link
Contributor Author

@swift-ci smoke test macOS

1 similar comment
@stephentyrone
Copy link
Contributor Author

@swift-ci smoke test macOS

@stephentyrone
Copy link
Contributor Author

@swift-ci please smoke test

yas375
yas375 reviewed Jul 10, 2019
View reviewed changes
stdlib/public/core/CollectionDifference.swift
@@ -222,7 +222,11 @@ public struct CollectionDifference<ChangeElement> {
/// }
/// }
/// ```
<<<<<<< HEAD
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably wasn't intended to be committed. There are a few of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I’m reworking some of this anyway to minimize the churn.

@stephentyrone stephentyrone mentioned this pull request Jul 12, 2019
Merged
@stephentyrone
Copy link
Contributor Author

Closing this in favor of simpler #26108 + follow-on PR for test/*.

@stephentyrone stephentyrone deleted the availability-9999 branch July 12, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yas375 yas375 yas375 left review comments

@jckarter jckarter jckarter approved these changes

@lorentey lorentey lorentey approved these changes

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephentyrone @swift-ci @lorentey @jckarter @yas375