Skip to content

validation-test: avoid shell in HashingRandomization #25232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jun 4, 2019

Split up the commands into multiple RUN lines. Use a temporary to
actually capture the output of multiple invocations to compose them into
a single stream.

Replace the export usage with env which the lit interpreter is able
to process even on Windows.

This makes HashingRandomization pass on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Split up the commands into multiple RUN lines.  Use a temporary to
actually capture the output of multiple invocations to compose them into
a single stream.

Replace the `export` usage with `env` which the lit interpreter is able
to process even on Windows.

This makes HashingRandomization pass on Windows.
@compnerd
Copy link
Member Author

compnerd commented Jun 4, 2019

CC: @lorentey

@compnerd
Copy link
Member Author

compnerd commented Jun 4, 2019

@swift-ci please test

@compnerd compnerd merged commit c1d007a into swiftlang:master Jun 4, 2019
@compnerd compnerd deleted the hash branch June 4, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant