Skip to content

validation-test: make stdlib.string compile on Win32 #25242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jun 4, 2019

The C library functions used here do not appear without the C runtime
being imported (ucrt or MSVCRT). Adjust the test as such. This exposes
a stack corruption in the test which needs to be resolved.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The C library functions used here do not appear without the C runtime
being imported (ucrt or MSVCRT).  Adjust the test as such.  This exposes
a stack corruption in the test which needs to be resolved.
@compnerd
Copy link
Member Author

compnerd commented Jun 4, 2019

@swift-ci please smoke test and merge

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Jun 4, 2019

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 61aab1d into swiftlang:master Jun 4, 2019
@compnerd compnerd deleted the strings-are-built branch June 4, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants