[AutoDiff] Unify adjoint entry block generation with the general logic. #25255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In control flow AD support, the logic that handles non-entry adjoint block generation should not be different than the general logic that generates intermediate blocks and processes active values. The only special thing about the adjoint entry block is that it need no phi args because the original block (the original exit) has no successors. This PR unifies the block generation logic, moving us a bit closer to the memory leak fix.
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Jun 5, 2019
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In control flow AD support, the logic that handles entry adjoint block generation should not be different than the general logic that generates intermediate blocks and processes active values. The only special thing about the entry adjoint block is that it need no phi args because its corresponding original block (the original exit) has no successors.
This PR unifies the block generation logic, moving us a bit closer to the memory leak fix.