[AutoDiff] Serialize/Deserialize linear, make Attribute reflect whether Function is linear.
#25269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a 'linear` argument to '@differentiable' attribute - 'linear' argument is optional, but when added, needs to be the first argument in the attribute
bartchr808
commented
Jun 5, 2019
dan-zheng
reviewed
Jun 5, 2019
bartchr808
commented
Jun 5, 2019
| @@ -1505,7 +1505,7 @@ ERROR(attr_differentiable_expected_label,none, | |||
| ERROR(attr_differentiating_expected_original_name,PointsToFirstBadToken, | |||
| "expected an original function name", ()) | |||
| ERROR(attr_differentiating_expected_label_linear_or_wrt,none, | |||
| "expected either 'linear' or 'wrt:'", ()) | |||
| "expected either 'linear' or 'wrt:'", ()) | |||
There was a problem hiding this comment.
Missed PR request that @rxwei caught from a previous PR (thanks!)
bartchr808
force-pushed
the
modify-diff-attrs-linear
branch
from
653fd36 to
ea49487
Compare
rxwei
approved these changes
Jun 5, 2019
|
@swift-ci please test tensorflow |
|
"Swift Test macOS Platform (TensorFlow)" is having issues (already known), so will merge it in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of work on the
linearargument to the@differentiableand@differentiatingattributes. This PR:DifferentiableAttrandDifferentiatingAttrobject reflect whether the function is marked as linear or not, instead of defaulting to false like I did temporarily in previous PRslinearargument