[5.1][Sema] Treat static methods as always applying their curried self param #25288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `areConservativelyCompatibleArgumentLabels` treats a reference to a declaration as not applying its curried self parameter if it doesn't have a base type. However this isn't correct for static operators, which have their Self.Type parameter applied but don't have a base type. This commit changes `areConservativelyCompatibleArgumentLabels` to always treat static methods as having their Self.Type parameters applied, as there's currently no way to form an unapplied curried reference to them. Resolves SR-10843.
|
Ping @slavapestov @xedin |
|
@swift-ci please test and merge |
|
Test failures look unrelated as far as I can tell |
|
@swift-ci please test and merge |
|
Unrelated build failures this time... hopefully third time lucky! |
|
@swift-ci please test and merge |
|
Thanks @xedin! |
|
No problem! |
|
Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Currently
areConservativelyCompatibleArgumentLabelstreats a reference to a declaration as not having its curried self parameter applied if the choice doesn't have a base type. However this isn't correct for operators defined as static methods, which have theirSelf.Typeparameter applied but their choice doesn't have a base type.This PR changes
areConservativelyCompatibleArgumentLabelsto always treat static methods as having theirSelf.Typeparameters applied, as there's currently no way to form an unapplied curried reference to them.Scope: Resolves a 5.1 regression.
SR Issue: SR-10843.
Risk: Low, the fix is fairly narrow.
Testing: Added a regression test.
Reviewers: @slavapestov @xedin.