Skip to content

[ConstraintSystem] Refactor openGeneric/openFunctionType #25291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 8, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 6, 2019

Summary:

  • Remove unused parameters
  • Extract logic related to opening generic parameters into openGenericParameters
  • Remove skip* boolean flags from everywhere expect to openGenericRequirements
  • Remove code duplication in CSRanking

@xedin xedin requested review from slavapestov and DougGregor June 6, 2019 19:05
@xedin
Copy link
Contributor Author

xedin commented Jun 6, 2019

This is actually a net negative loc PR which is NFC-ish :)

@xedin
Copy link
Contributor Author

xedin commented Jun 7, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jun 7, 2019

@swift-ci please test source compatibility

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Jun 8, 2019

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Jun 8, 2019

Looks like source compat suite fails with the same errors as master branch which are unrelated to my changes.

@xedin xedin merged commit 00e30dd into swiftlang:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants