Skip to content

[windows] Fix usage of strtof/d/ld function usage. #25292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2019

Conversation

drodriguez
Copy link
Contributor

The error conditions for underflow or overflow weren't being checked,
which caused problems in some tests.

The error conditions for underflow or overflow weren't being checked,
which caused problems in some tests.
@drodriguez drodriguez requested a review from compnerd June 6, 2019 20:11
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh nice find

@compnerd
Copy link
Member

compnerd commented Jun 7, 2019

@swift-ci please test and merge

@compnerd
Copy link
Member

compnerd commented Jun 7, 2019

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jun 7, 2019

Build failed
Swift Test OS X Platform
Git Sha - 19a1e2c

@compnerd
Copy link
Member

compnerd commented Jun 8, 2019

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jun 8, 2019

Build failed
Swift Test OS X Platform
Git Sha - 19a1e2c

@compnerd
Copy link
Member

compnerd commented Jun 8, 2019

@swift-ci please smoke test macOS platform

@compnerd compnerd merged commit 2bc397b into swiftlang:master Jun 8, 2019
@drodriguez drodriguez deleted the windows-fix-numeric-parsing branch July 8, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants