Skip to content

[benchmark] RandomIntegersLCG future-proofed #25295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

palimondo
Copy link
Contributor

Allow for future change in algorithm that generates random integers in range.

See PR #25286.

Allow for future change in algorithm that generates random integers in range.
@palimondo
Copy link
Contributor Author

@swift-ci benchmark

@palimondo
Copy link
Contributor Author

@swift-ci smoke test

@palimondo palimondo changed the title [benchmark] RandomIntegersLCG futureproofed [benchmark] RandomIntegersLCG future-proofed Jun 7, 2019
@swift-ci
Copy link
Contributor

swift-ci commented Jun 7, 2019

Performance: -O

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeStubFromNSStringRef 158 176 +11.4% 0.90x (?)
StringBuilderWithLongSubstring 1330 1440 +8.3% 0.92x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayAppendGenericStructs 2110 1360 -35.5% 1.55x (?)

Code size: -O

Improvement OLD NEW DELTA RATIO
RandomValues.o 3774 3006 -20.3% 1.26x

Performance: -Osize

Regression OLD NEW DELTA RATIO
ArrayAppendGenericStructs 2120 2410 +13.7% 0.88x (?)
SortLettersInPlace 514 561 +9.1% 0.92x (?)

Code size: -Osize

Improvement OLD NEW DELTA RATIO
RandomValues.o 3415 2679 -21.6% 1.27x

Performance: -Onone

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 9000 9950 +10.6% 0.90x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayAppendOptionals 2350 1380 -41.3% 1.70x (?)
StringToDataLargeUnicode 4250 3900 -8.2% 1.09x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@palimondo palimondo merged commit c80d243 into swiftlang:master Jun 7, 2019
@palimondo palimondo deleted the futureproof-randLCG-bench branch June 7, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants