[clf] Simplify the double diamond lifetime extension for escaping swi… #25320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
…ft funcs -> noescape blocks. Specifically, when we optimize conversions such as: Optional<@escaping () -> ()> -> Optional<@NoEscape () -> ()> -> Optional<@NoEscape @convention(block) () -> ()> previously we were lifetime extending over the @NoEscape lifetime barrier by making a copy and then putting a mark_dependence from the copy onto the original value. This was just a quick way to tell the ownership verifier that the copy was tied to the other value and thus should not be eliminated. The correctness of the actual lifetime extension comes from the optimizer being conservative around rr insts. This commit instead changes our optimization to borrow the copied optional value, extract the payload, and use that instead.
gottesmm
force-pushed
the
pr-393856a2bc74013494a4598e46d156795de076f2
branch
from
d150ffb to
cf0405c
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ft funcs -> noescape blocks.
Specifically, when we optimize conversions such as:
previously we were lifetime extending over the @NoEscape lifetime barrier by
making a copy and then putting a mark_dependence from the copy onto the original
value. This was just a quick way to tell the ownership verifier that the copy
was tied to the other value and thus should not be eliminated. The correctness
of the actual lifetime extension comes from the optimizer being conservative
around rr insts.
This commit instead changes our optimization to borrow the copied optional
value, extract the payload, and use that instead.