[5.1] Introduce a backward-deployment library for SR-10600. #25330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build a static archive that can be linked into executables and take advantage of the Swift runtime's hooking mechanism to work around the issue Doug fixed in swiftlang#24759. The Swift 5.0 version of swift_conformsToProtocol would return a false negative in some cases where a subclass conforms using an inherited conformance, so work around this by successively retrying the original implementation up the superclass chain to try to find a match.
Many build systems that support Swift don't use swiftc to drive the linker. To make things easier for these build systems, also use autolinking to pull in the needed compatibility libraries. This is less ideal than letting the driver add it at link time, since individual compile jobs don't know whether they're building an executable or not. Introduce a `-disable-autolink-runtime-compatibility` flag, which build systems that do drive the linker with swiftc can pass to avoid autolinking. rdar://problem/50057445
Although it's a static archive, its use is only relevant to dynamically linked builds of the standard library. (If you're statically linking a Swift runtime into your process, you don't need to worry about compatibility with older runtimes.)
|
@swift-ci Please test |
|
Please test with following pull request: @swift-ci Please test |
|
Please test with following pull request: @swift-ci Please test |
|
Build failed |
|
@swift-ci Please test OS X |
|
Build failed |
|
@swift-ci Please test OS X |
|
Build failed |
|
Please test with following pull request: @swift-ci Please test OS X |
jckarter
added a commit
to jckarter/swift-package-manager
that referenced
this pull request
Jun 12, 2019
Using Swift to link pure C targets relies on a new Swift driver flag introduced in swiftlang/swift#25330. Stage this in by disabling tests until that change propagates. rdar://problem/50057445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build a static archive that can be linked into executables and take advantage of the Swift runtime's
hooking mechanism to work around the issue Doug fixed in #24759.
The Swift 5.0 version of swift_conformsToProtocol would return a false negative in some cases where
a subclass conforms using an inherited conformance, so work around this by successively retrying
the original implementation up the superclass chain to try to find a match.
rdar://problem/50057445