[ConstraintSystem] Use lightweight conformance check in determining w… #25348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
approved these changes
Jun 11, 2019
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@shahmishal Looks like there are a lot of lldb failures, have you seen anything like that recently? |
|
@swift-ci please smoke test macOS platform |
…hether literal could be initialized via coercion Currently logic to transform call into coercion uses `conformsToProtocol` to validate that type conforms to one of the ExpressibleBy*Literal protocols. That function doesn't handle unbound generic parameters and would result in an infinite loop or a crash when not all of the generic parameters were explicitly specified for one of the types in the chain e.g. `A.B(42)` where `A` has at least one generic parameter. Resolves: rdar://problem/50007727
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hether literal could be initialized via coercion
Currently logic to transform call into coercion uses
conformsToProtocolto validate that type conforms to one of the ExpressibleBy*Literal protocols.
That function doesn't handle unbound generic parameters and would result in
an infinite loop or a crash when not all of the generic parameters were
explicitly specified for one of the types in the chain e.g.
A.B(42)where
Ahas at least one generic parameter.Resolves: rdar://problem/50007727