Sema: Go back to synthesizing hashValue on _StoredBridgedNSError conformers #25349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormers Commit e0bba70 added a default implementation, however this is wrong for non-imported types. Instead, synthesize the body as before. Since this is one of the few derived methods that can appear on an imported type, make sure to build fully type-checked AST. Fixes <rdar://problem/51322302>.
slavapestov
force-pushed
the
synthesized-hashValue-abi-break
branch
from
3f3bcf0 to
712927c
Compare
|
@swift-ci Please smoke test |
|
You're not supposed to use that protocol with non-imported types. |
|
We have |
|
Okay, but that's because those are emulating imported types, and I wouldn't expect their |
|
Yep, we can do that. I'm perfectly okay with either solution. |
|
Please revert this, then, @slavapestov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e0bba70 added a default implementation, however this is wrong
for non-imported types.
Instead, synthesize the body as before. Since this is one of the few
derived methods that can appear on an imported type, make sure to
build fully type-checked AST.
Fixes rdar://problem/51322302.