Skip to content

test: make StdlibUnittest.CrashingTests pass on Windows #25366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

compnerd
Copy link
Member

The output can be interleaved differently. Accept either ordering.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The output can be interleaved differently.  Accept either ordering.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

CC: @kubamracek

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4c91a3e

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4c91a3e

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4c91a3e

@compnerd
Copy link
Member Author

sigh lldb again

@compnerd
Copy link
Member Author

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4c91a3e

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4c91a3e

@compnerd compnerd merged commit 40c9851 into swiftlang:master Jun 13, 2019
@compnerd compnerd deleted the order-independence branch June 13, 2019 03:23
@drodriguez
Copy link
Contributor

So I think I have some idea why this one was needed and why is failing again in Azure in another of the test. For all the platforms except Windows, the stdlib unit test framework uses select to read from the pipes connected to the stdout and stderr of the test processes. select should maintain the relative order of the messages generated by the test process. However, in Windows, we spin two threads that read from the handles "at the same time", which will not maintain the relative order.

I tried to play a little and enable using select also in Windows, but I got into a lot of dead ends. I wonder if there's a better alternative to the two threads in Windows. Something that can maintain the relative order of the events without leaving it to the scheduler.

Adding DAG to more cases is not only a nuisance, but also wrong, because output happens before error, but the test is saying that it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants