Skip to content

[Sema] Bail early in exportability checker if there's no extended type #25373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2019
Merged

[Sema] Bail early in exportability checker if there's no extended type #25373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/Sema/TypeCheckAccess.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,7 +1872,12 @@ class ExportabilityChecker : public DeclVisitor<ExportabilityChecker> {
}

void visitExtensionDecl(ExtensionDecl *ED) {
if (shouldSkipChecking(ED->getExtendedNominal()))
auto extendedType = ED->getExtendedNominal();
// TODO: Sometimes we have an extension that is marked valid but has no
// extended type. Assert, just in case we see it while testing, but
// don't crash. rdar://50401284
assert(extendedType && "valid extension with no extended type?");
if (!extendedType || shouldSkipChecking(extendedType))
return;

// FIXME: We should allow conforming to implementation-only protocols,
Expand Down