[ConstraintSystem] Replace special locator for return of single expr … #25383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function with a flag on contextual type locator It's only needed in one place in the constraint solver to allow `() -> T` to `() -> ()` and `() -> Never` to `() -> T` for expressions representing return of a single expression functions, so to simplify contextual type handling in diagnostic and other places it would be better to replace dedicated locator kind with a flag on existing `ContextualType`. Resolves: rdar://problem/51641323
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility debug |
|
@swift-ci please build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
DougGregor
approved these changes
Jun 12, 2019
|
macOS Toolchain Install command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…function with a flag on contextual type locator
It's only needed in one place in the constraint solver to allow
() -> Tto() -> ()and() -> Neverto() -> Tfor expressionsrepresenting return of a single expression functions, so to simplify
contextual type handling in diagnostic and other places it would be
better to replace dedicated locator kind with a flag on existing
ContextualType.Resolves: rdar://problem/51641323