[Definite Initialization] Fix a bug that made DI wrongly think that an unused access to "self" in a delegating initializer is a use of the form: type(of:self)
#25403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that an unused access to "self" in a delegating initializer is a use of the form: `type(of:self)` <rdar://51198592>
ravikandhadai
changed the title
type(of:self)type(of:self)
|
@swift-ci Please smoke test |
|
@swift-ci smoke test macOS platform |
|
@ravikandhadai we should put this in 5.1 as well. |
|
Thanks Ravi! |
This was referenced Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://51198592
This fixes a bug in the function
collectDelegatingInitUsesthat classifies uses of an uninitialized memory location. The code that had to check that every use of aload_borrowinst (expect the correspondingend_borrow) was in aValueMetatypeInstdid not consider the case where there is no use of theload_borrowat all.