Convert DictionaryExpr to not use tc.callWitness() or generate a SemanticExpr. #25408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
approved these changes
Jun 13, 2019
…nticExpr. For reference, everything else except string interpolation has been migrated to this new form.
|
@swift-ci please test |
|
Yes, I think InterpolatedStringExpr is the last Expr that uses the SemanticExpr solution. |
|
Build failed |
|
Build failed |
slavapestov
reviewed
Jun 17, 2019
| @@ -1426,10 +1413,6 @@ namespace { | |||
| // we go digging through failed constraints, and expect their locators to | |||
| // still be meaningful. | |||
| ~ExprTypeSaverAndEraser() { | |||
| for (auto CSE : CollectionSemanticExprs) | |||
There was a problem hiding this comment.
I love that ExprTypeSaverAndEraser becomes simpler as well (ideally it wouldn't exist; there's a lot of refactoring before we can do that though!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, everything else except string interpolation has been
migrated to this new form.