-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SDK] Adjust dependency script & regenerate dependencies #25425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci clean test |
Build failed |
@swift-ci clean test macOS |
Build failed |
Make sure you do the generation against the internal SDKs. Better to have too many dependencies than not enough. |
11281 failures are a few more than I expected. |
@swift-ci clean test macOS platform |
329872f
to
3045006
Compare
@swift-ci test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@swift-ci clean test |
Build failed |
That was slightly too many additions -- we have two cycles now: Dispatch → os → Dispatch
|
Hm, |
@jrose-apple did you mean Dispatch depends on os?
|
No,
|
- Don’t special-case Foundation. - Don’t update files if the only change is in the ordering. - Match for a space after CMAKE_DEPENDS_NAME.
This isn’t hardcoded into the dependency detection script anymore.
3045006
to
09c8997
Compare
Rebased and reverted back to the public SDK. @swift-ci test |
The overlay dependencies are a bit out date with the SDKs that are in Xcode 11 beta 1, and this causes CI issues. Adjust the script to reduce the amount of noise it generates and regenerate overlay dependencies.
rdar://problem/51634433