[tensorflow] make SourceKit use an inmemory filesystem for clang module cache #25438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmako
approved these changes
Jun 13, 2019
| break; | ||
| #else | ||
| llvm::errs() << "in-memory-clang-module-cache only supported when " | ||
| "SWIFT_SOURCEKIT_USE_INPROC_LIBRARY is set"; |
There was a problem hiding this comment.
Could you elaborate on the reasons behind this restriction?
tools/SourceKit/tools/sourcekitd/include/sourcekitd/FileSystemProvider.h
Outdated
Show resolved
Hide resolved
Co-Authored-By: Eugene Burmako <[email protected]>
Co-Authored-By: Eugene Burmako <[email protected]>
Co-Authored-By: Eugene Burmako <[email protected]>
Co-Authored-By: Eugene Burmako <[email protected]>
…Provider.h Co-Authored-By: Eugene Burmako <[email protected]>
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context about the problem: We'd like to run SourceKit on a server where we're not allowed to write to the filesystem. The ClangImporter writes module caches to the filesystem, so we need some way to stop that from happening.
This PR solves the problem by using the
InMemoryOutputFileSystemdefined in apple/swift-clang#330.This may only be a temporary solution, but everything else I tried was quite hard to get working (explicitly building required clang modules before invoking SourceKit, so that SourceKit doesn't have to build the modules into the cache), so I'd like to try this for a while.