Fix crash when refining protocol from a testable import #25445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tocol requirements
…irements The way this predicate is used is closely intertwined with 'can have open access'. For example, we don't want protocol requirements coming from testable imports to have 'open' access level.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
jrose-apple
reviewed
Jun 14, 2019
| @@ -7177,8 +7177,7 @@ inline bool Decl::isPotentiallyOverridable() const { | |||
| isa<SubscriptDecl>(this) || | |||
| isa<FuncDecl>(this) || | |||
| isa<DestructorDecl>(this)) { | |||
| return getDeclContext()->getSelfClassDecl() || | |||
| isa<ProtocolDecl>(getDeclContext()); | |||
There was a problem hiding this comment.
Oh. We just…didn't need the protocol case? Oh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were giving protocol requirements 'open' access, which trips up other code that assumes 'open' implies its inside a class. Tighten the screws a little so that this no longer happens.
Fixes rdar://problem/51108930, https://bugs.swift.org/browse/SR-10761.