[5.1 06/12][CSApply] Don't try to transform editor placeholder if it's type is invalid #25463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If solution application is attempted for one of the sub-expressions, while diagnostics are trying to narrow down where the failure is located, don't record that captures need to be computed for closures, because that could fail later on as in such conditions expressions are not guaranteed to have correct types (e.g. some types could be set to "unresolved"). (cherry picked from commit 59bc60e)
…nvalid CSDiag could re-typecheck closure or other expression which has editor placeholder inside allowing type variables be bound to unresolved type, which doesn't really form a valid solution to be applied to AST. So we need to guard against trying to transform placeholder into a call to `_undefined` in such case, otherwise in asserts build it's going to crash with an assert but in release build it would crash in some other place e.g. xSILGen or trying to type-check captures. Resolves: rdar://problem/48937223 Resolves: rdar://problem/51599529 (cherry picked from commit 26d0324)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: CSDiag could re-typecheck closure or other expression which has
editor placeholder inside allowing type variables be bound to unresolved
type, which doesn't really form a valid solution to be applied to AST.
So we need to guard against trying to transform placeholder into a call
to
_undefinedin such case, otherwise in asserts build it's going to crashwith an assert but in release build it would crash in some other place e.g.
SILGen or trying to type-check captures.
Issue: rdar://problem/48937223, rdar://problem/51599529
Scope: Diagnostics, in subset of cases when failure detector tries to re-typecheck closures with editor placeholders in them.
Risk: Low.
Testing: Added compiler regression tests.
Reviewed by: @DougGregor
Resolves: rdar://problem/48937223
Resolves: rdar://problem/51599529