[cast-optimizer] Fix a leak in the cast optimizer when we perform loa… #25470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d promotion and fail. Specifically, in this part of the cast optimizer we are trying to optimize casts that can be done in two parts. As an example consider: NSObject -> Array<Any>. In this case, we first cast from NSObject -> NSArray and then try to conditionally bridge to Array<Any> from NSArray. The problem is we did not destroy the NSObject correctly if the first cast failed. I couldn't figure out how to create an actual swift test case that produces this problem since we are pretty conservative about triggering this code path. But in SIL it is pretty easy and in ossa, we trigger the ownership verifier. This is another victory for the ownership verifier! rdar://51753580
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d promotion and fail.
Specifically, in this part of the cast optimizer we are trying to optimize casts
that can be done in two parts. As an example consider: NSObject ->
Array. In this case, we first cast from NSObject -> NSArray and then try to
conditionally bridge to Array from NSArray.
The problem is we did not destroy the NSObject correctly if the first cast
failed. I couldn't figure out how to create an actual swift test case that
produces this problem since we are pretty conservative about triggering this
code path. But in SIL it is pretty easy and in ossa, we trigger the ownership
verifier.
This is another victory for the ownership verifier!
rdar://51753580