[5.1 06/12][ConstraintSystem] Detect and diagnose missing generic arguments #25486
+585
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a fix to detect and diagnose situations when omitted
generic arguments couldn't be deduced by the solver based on
the enclosing context.
Example:
```swift
struct S<T> {
}
_ = S() // There is not enough context to deduce `T`
```
Resolves: rdar://problem/51203824
(cherry picked from commit bfe1987)
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generic arguments couldn't be deduced by the solver based on
the enclosing context.
Example:
Issue: rdar://problem/51203824, rdar://problem/50512161
Scope: Diagnostics, in subset of cases where solver couldn't resolve some of the arguments for generic parameters
Risk: Low.
Testing: Added compiler regression tests and adjusted existing ones.
Reviewed by: @DougGregor, @slavapestov
Resolves: rdar://problem/51203824
Resolves: rdar://problem/50512161
(cherry picked from commit bfe1987)