[5.1] [ModuleInterface] Qualify all types in module interfaces #25488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed by @jrose-apple |
harlanhaskins
changed the title
|
@swift-ci please test |
|
Build failed |
|
Build failed |
added 5 commits
June 17, 2019 10:00
We should not be making assumptions about module lookup when we're compiling a module interface, so instead print the types fully qualified. rdar://48445154
There are still cases (a module with a type that's the same name as the module) where we cannot fully qualify all types. In those cases, allow them to remain unqualified with a flag, `-Xfrontend -preserve-types-as-written-in-module-interface`.
This check wasn't ever correct, because the fact that the the protocol comes
from another module doesn't change the fact that the type is valid for lookup
within this module. It incorrectly rejects the following, valid code:
```swift
// In A.swift
public protocol A {}
```
```
// In B.swift
import A
extension A {
typealias B = Int
func b(_ b: Self.B) {}
}
```
harlanhaskins
force-pushed
the
property-reprs-5.1
branch
from
cb89e02 to
ed62e24
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be making assumptions about module lookup when we're
compiling a module interface, so instead print the types fully
qualified.
rdar://48445154