[Sema] Always create memberwise init when deriving AdditiveArithmetic.
#25495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, during `AdditiveArithmetic` derived conformances, memberwise initializers were synthesized only when synthesizing `static var zero`. This led to a crash for types that specified `static var zero` but not other requirements. Resolves TF-579.
rxwei
approved these changes
Jun 15, 2019
Co-Authored-By: Richard Wei <[email protected]>
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, during
AdditiveArithmeticderived conformances, memberwiseinitializers were synthesized only when synthesizing
static var zero.This led to a crash for types that specified
static var zerobut notother requirements.
Resolves TF-579.